Repository is now instanciated on the fly #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing tho |
|
Right, there was a test conflicting with the very purpose of this pull request. I removed this test. There are still some failing tests, but I guess these out of memory errors are unrelated. |
|
The unit tests have improved greatly the last couple of weeks. Could you rebase on top of master? |
abienvenu
force-pushed
the
onthefly_repo
branch
3 times, most recently
from
25b47fa to
4b2db2d
Compare
This avoids a database connection to be established for every request Fixes issue FriendsOfSymfony#422
abienvenu
force-pushed
the
onthefly_repo
branch
from
48bf733 to
208110e
Compare
|
Ok @dinamic , I made the rebase and tests are fine now. |
|
Can you handle authcodemanagers too? |
This avoids a database connection to be established for every request Completes fix for issue FriendsOfSymfony#422
|
Yes @dkarlovi, good point. AuthCodeManagers are handled as well now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more repository instantiated in constructor of ClientManager and TokenManager.
This avoids a database connection to be established for every request.
Fixes issue #422